refactor: update documentation about generating JS examples #1348
Conversation
update the JS output accordingly also
|
Mhh, the failing "coding style check" seems to have something to do with my local setup. See also #1349 |
| @@ -13,6 +13,7 @@ | |||
| * | |||
| * SPDX-License-Identifier: EPL-2.0 OR W3C-20150513 | |||
| ********************************************************************************/ | |||
| Object.defineProperty(exports, "__esModule", { value: true }); | |||
There was a problem hiding this comment.
This should not be there (according to the tests that I did in the past), I'll double-check locally to understand why it generates this line now.
| /******************************************************************************** | ||
| * Copyright (c) 2022 Contributors to the Eclipse Foundation | ||
| * Copyright (c) 2021 Contributors to the Eclipse Foundation |
There was a problem hiding this comment.
These license changes are ok? should we maybe update the ones coming from TS ? are they good?
There was a problem hiding this comment.
I noticed that also, but I think we should not bother too much. I think updating according to TS files is fine...
What I don't understand is how does the prettier GH action gets the information which prettier options are to be used. Does it just pick up .prettierrc.json from the repository? node-wot/.github/workflows/ci.yaml Lines 102 to 109 in 4d083fc |
Update the JS output accordingly also
fixes #1347